[cvsnt-commits] Cvs Commit: cvsnt

arthur.barrett at march-hare.com arthur.barrett at march-hare.com
Sat Oct 27 22:35:19 BST 2007


Community technical support mailing list was retired 2010 and replaced with a professional technical support team. For assistance please contact: Pre-sales Technical support via email to sales@march-hare.com.


CVSROOT:	/usr/local/cvs
Module name:	cvsnt
Changes by:	arthur.barrett at march-hare.com		Sat Oct 27 21:25:54 2007
On host:	mail.march-hare.com

Directory: cvsnt/cvsapi

M TranslatedFileAccess.cpp		1.9 -> 1.10	Bug Id: 
M TranslatedFileAccess.h		1.4 -> 1.5	Bug Id: 

Directory: cvsnt/cvsapi/evsapitest

M evsapitest.cpp		1.1 -> 1.2	Bug Id: 

Directory: cvsnt/cvsapi/win32

M RunFile.cpp		1.16 -> 1.17	Bug Id: 

Directory: cvsnt/src

M commit.cpp		1.133 -> 1.134	Bug Id: 
M hash.cpp		1.17 -> 1.18	Bug Id: 
M logmsg.cpp		1.43 -> 1.44	Bug Id: 
M logmsg.h		1.2 -> 1.3	Bug Id: 

Log message:
Fixed a crash and also broken feature(s) when you commit without -m

Prior to this fix, if a commit was done without specifying a comment 
then the EVS client would crash before displaying the notepad for the
user to enter the comment.

Once the crash was fixed the notepad displayed junk.

Once the notepad display was fixed then half the lines in the notepad
(the lines that displayed the "modified files" did not have correct
line endings).  This was the most difficult to track down and fix.

The problem ended up being that the TranslatedFileIO class was cast 
into a FileIO class, and therefore the line endings changed halfway
through the file write.  Fixing the function prototypes to use
TranslatedfileIO and removing the cast has fixed the problem.

Ive only had time to test the "message" implementation, and only the
"MOdified Files" path, though I've given the rest a cursory visual
inspection.





More information about the cvsnt-commits mailing list