Code Review File Created by Mitch Davis, using makereviewdiff 2.3 Created on Fri Feb 13 16:17:36 EST 2004 Script run from directory /home/EXTEL.COM.AU/mitch_davis/rd P3142 EXPANdsl R2 Implementation -------- Change comments ------- A: Removed operator >=, since priority() is now public. B: Made two methods const, to avoid compiler error. C: Did a lot of work on detecting errors and handling them as best we can. Includes trying to release messages if no-one else is going to. D: Changed the timeout and transmit queue instances from pointers to attributes. E: Shortened a bunch of debugging strings, as the logging macro includes the process name. ------------ Summary ----------- ---- Changed Files ---- A source/muo/iup/IUPMessage.h 5 B source/muo/iup/PriorityQueue.h 36 C source/muo/iup/adaptor/IUPAdaptor.cc 75 CDE source/muo/iup/channel/IUPChannel.cc 184 D source/muo/iup/channel/IUPChannel.h 984 --------- End of Summary ------- 1 Index: source/muo/iup/IUPMessage.h 2 =================================================================== 3 RCS file: /home/cvs/isos/source/muo/iup/Attic/IUPMessage.h,v 4 retrieving revision 1.1.4.7 #### Changes to file source/muo/iup/IUPMessage.h --- source/muo/iup/IUPMessage.h +++ source/muo/iup/IUPMessage.h 5 @@ -41,10 +41,6 @@ 6 friend class IUPAdaptor; // So Adaptor can set error codes, etc. 7 friend class IUPChannel; // So channel can set errors, construct responses, etc. 8 9 - // This operator is to sort the messages by expiry time in 10 - // the channel timeout queue. 11 - friend bool operator>=(const IUPMessage &e1, const IUPMessage &e2); 12 - 13 public: 14 // This enum represents the different IUP message types. 15 typedef enum 16 @@ -62,6 +58,7 @@ 17 const U32 error() const {return _h ? _h->error : ENOMEM;} 18 19 const MessageType type() const {return (MessageType)_h->type;} 20 + const U32 priority() const {return _prio;}