Hi Tony, 

Thanks for looking at bug #4, which I reported: 

  http://www.cvsnt.org/cgi-bin/bugzilla/show_bug.cgi?id=4 

> This will break if you have a CVS_RSH program that 
> needs extra parameters. 

CVS_RSH should not be used to add parameters, and actually 
under Unix CVS, extra parameters will cause CVS to fail, as 
shown on this Unix box: 

cvssrv [~] export CVS_RSH="/usr/bin/ssh" 
cvssrv [~] cvs -d :ext:cvssrv:/home/cvs co -c 
56k          ram8-v90 
cvssrv [~] export CVS_RSH="/usr/bin/ssh -v" 
cvssrv [~] cvs -d :ext:cvssrv:/home/cvs co -c 
cvs [checkout aborted]: cannot exec /usr/bin/ssh -v: No such file or directory 
cvs [checkout aborted]: end of file from server (consult above messages if any) 

This is because under Unix, the value of CVS_RSH is not reparsed, 
which is correct.  Under Unix, if you need extra options, the 
solution is to make a "wrapper" shell script which adds your options, 
and I think it should be the same under Windows. 

> Since there's an easy workaround 

Both workarounds have problems: 

 - Explicitly adding double quotes to the value of CVS_RSH 
   works for CVSNT, but causes other CVS clients to break. 
   (I added double quotes just to show that the snprintf 
   with backslashed quotes would work as required).

 - Putting the short name (ie, "E:\Progra~1\PuTTY\plink.exe") 
   will not always work, because under some filesystems and 
   with some registry options, there *are* no short names. 
   (See III.2.2 in the following) 

     http://www.cert.org/advisories/CA-98.04.Win32.WebServers.html 

   Also, the installation program I use to push CVS onto our 
   company PCs doesn't know about short names, only long 
   names. 

Tony, please consider reopening this bug.  In this respect 
(CVS_RSH shouldn't be reparsed) I think CVSNT should 
work like CVS under Unix.  Extra options are still 
possible with a wrapper. 

Thanks, 

Mitch. 
--- 
mailto:mjd@alphalink.com.au